linux-kernel - Re: [PATCH v22 1/8] dt-bindings: clock: npcm845: Add reference 25m clock property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Jan 2024 21:54:14 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tomer Maimon <tmaimon77@...il.com>, Rob Herring <robh@...nel.org>
Cc: mturquette@...libre.com, sboyd@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, tali.perry1@...il.com, joel@....id.au,
 venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
 openbmc@...ts.ozlabs.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v22 1/8] dt-bindings: clock: npcm845: Add reference 25m
 clock property

On 10/01/2024 14:47, Tomer Maimon wrote:
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: refclk
>>> +
>>>    '#clock-cells':
>>>      const: 1
>>>      description:
>>> @@ -30,12 +38,20 @@ properties:
>>>  required:
>>>    - compatible
>>>    - reg
>>> +  - clocks
>>> +  - clock-names
>>
>> New required properties are an ABI break. That's fine if you explain why
>> that's okay in the commit msg.
> What do you mean?

I think it was clear. Which part is not clear?

> Could I add the new required properties to the required list?

You just did, didn't you? And received feedback that you are breaking
the ABI.

Best regards,
Krzysztof