linux-kernel - Re: [PATCH v22 6/8] dt-bindings: clock: npcm845: replace reg with syscon property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171300da-3d49-4e1f-8969-9a454ecdd698@linaro.org>
Date: Wed, 10 Jan 2024 21:59:37 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tomer Maimon <tmaimon77@...il.com>, mturquette@...libre.com,
 sboyd@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 tali.perry1@...il.com, joel@....id.au, venture@...gle.com, yuenn@...gle.com,
 benjaminfair@...gle.com
Cc: openbmc@...ts.ozlabs.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v22 6/8] dt-bindings: clock: npcm845: replace reg with
 syscon property

On 08/01/2024 14:54, Tomer Maimon wrote:
> Replace reg with syscon property since the clock registers handle the
> reset registers as well.
> 
> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>
> ---
>  .../bindings/clock/nuvoton,npcm845-clk.yaml   | 22 +++++++++----------
>  1 file changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> index 0b642bfce292..c6bf05c163b4 100644
> --- a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> @@ -18,8 +18,9 @@ properties:
>      enum:
>        - nuvoton,npcm845-clk
>  
> -  reg:
> -    maxItems: 1
> +  nuvoton,sysclk:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to access clock registers.

NAK. Not explained, not justified, not reasonable, breaking ABI.

Best regards,
Krzysztof