linux-kernel - Re: [PATCH v2] ksmbd: free ppace array on error in parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd8g4k8kF+GyOv-jX5mw+PtKb9HxLrcWy5c4qpFwXFPTAQ@mail.gmail.com>
Date: Wed, 10 Jan 2024 09:28:16 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Steve French <sfrench@...ba.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Tom Talpey <tom@...pey.com>, Hyunchul Lee <hyc.lee@...il.com>, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Alexey Khoroshilov <khoroshilov@...ras.ru>, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] ksmbd: free ppace array on error in parse_dacl

2024-01-09 23:14 GMT+09:00, Fedor Pchelkin <pchelkin@...ras.ru>:
> The ppace array is not freed if one of the init_acl_state() calls inside
> parse_dacl() fails. At the moment the function may fail only due to the
> memory allocation errors so it's highly unlikely in this case but
> nevertheless a fix is needed.
>
> Move ppace allocation after the init_acl_state() calls with proper error
> handling.
>
> Found by Linux Verification Center (linuxtesting.org).
>
> Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>
Applied it to #ksmbd-for-next-next.

Thanks for your patch!