linux-kernel - Re: [PATCH v2 0/2] lib min_heap: Min heap optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240109221447.3d5e8878b0d6424d26666be5@linux-foundation.org>
Date: Tue, 9 Jan 2024 22:14:47 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: irogers@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] lib min_heap: Min heap optimizations

On Thu,  4 Jan 2024 04:52:57 +0800 Kuan-Wei Chiu <visitorckw@...il.com> wrote:

> Hello,
> 
> The purpose of this patch series is to enhance the existing min heap
> implementation. The optimization focuses on both the heap construction
> process and the number of comparisons made during the heapify
> operation.
> 

The patches look nice, but the only user of this code is
kernel/events/core.c and the developers of that code aren't cc'ed, so
please rectify that.

Has Ian commented on these changes?

The amount of inlining in min_heap.h is amazing.  Was there some
special reason for this?  It makes min_heap somewhat unsuitable for
more general use.