linux-kernel - Re: crypto: virtio - Less function calls in __virtio_crypto_akcipher_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Jan 2024 08:46:21 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Justin Stitt <justinstitt@...gle.com>, virtualization@...ts.linux.dev,
 linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org,
 netdev@...r.kernel.org, cocci@...ia.fr
Cc: kernel test robot <lkp@...el.com>, "David S. Miller"
 <davem@...emloft.net>, Gonglei <arei.gonglei@...wei.com>,
 Herbert Xu <herbert@...dor.apana.org.au>, Jason Wang <jasowang@...hat.com>,
 "Michael S. Tsirkin" <mst@...hat.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, llvm@...ts.linux.dev,
 oe-kbuild-all@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: crypto: virtio - Less function calls in
 __virtio_crypto_akcipher_do_req() after error detection

>> The kfree() function was called in up to two cases by the
>> __virtio_crypto_akcipher_do_req() function during error handling
>> even if the passed variable contained a null pointer.
>> This issue was detected by using the Coccinelle software.
>
> If the script is short and simple would you mind, in the future,
> including it below the fold -- this may help others do similar work down
> the line -- Or …

Would you like to take another look at the clarification approach
“Reconsidering kfree() calls for null pointers (with SmPL)”?
https://lore.kernel.org/cocci/6cbcf640-55e5-2f11-4a09-716fe681c0d2@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2023-03/msg00096.html

Regards,
Markus