linux-kernel - Re: [PATCH v6 1/2] leds: trigger: netdev: display only supported link speed attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240110125454.GI7948@google.com>
Date: Wed, 10 Jan 2024 12:54:54 +0000
From: Lee Jones <lee@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Pavel Machek <pavel@....cz>,
	Marek Behún <kabel@...nel.org>,
	Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
	Daniel Golle <daniel@...rotopia.org>,
	"David S. Miller" <davem@...emloft.net>,
	Li Zetao <lizetao1@...wei.com>, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH v6 1/2] leds: trigger: netdev: display only supported
 link speed attribute

On Wed, 10 Jan 2024, Christian Marangi wrote:

> On Thu, Dec 21, 2023 at 06:11:24PM +0100, Christian Marangi wrote:
> > With the addition of more link speed mode to the netdev trigger, it was
> > pointed out that there may be a problem with bloating the attribute list
> > with modes that won't ever be supported by the trigger as the attached
> > device name doesn't support them.
> > 
> > To clear and address this problem, change the logic where these
> > additional trigger modes are listed.
> > 
> > Since the netdev trigger REQUIRE a device name to be set, attach to the
> > device name change function additional logic to parse the supported link
> > speed modes using ethtool APIs and show only the supported link speed
> > modes attribute.
> > 
> > Link speed attribute are refreshed on device_name set and on
> > NETDEV_CHANGE events.
> > 
> > This only apply to the link speed modes and every other mode is still
> > provided by default.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > Reviewed-by: Marek Behún <kabel@...nel.org>
> 
> Any news for this?

Not yet.  It's on the list.  Holidays, merge window, etc.

-- 
Lee Jones [李琼斯]