linux-kernel - Re: [PATCH] x86/mtrr: Check if fixed MTRRs exist before saving them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cyu9jmm5.ffs@tglx>
Date: Wed, 10 Jan 2024 15:20:50 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Andi Kleen <ak@...ux.intel.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mtrr: Check if fixed MTRRs exist before saving them

On Tue, Jan 09 2024 at 20:24, Andi Kleen wrote:
> On Tue, Jan 09, 2024 at 08:06:26PM +0100, Thomas Gleixner wrote:
>> On Fri, Jan 05 2024 at 08:37, Andi Kleen wrote:
>> > This one place forgot to check the fixed capability.
>> 
>> What's the consequence of that missing chec
>
> You get a WARN_ON for a WRMSR failing if you don't have the MSR.
>
>> and shouldn't this have a Fixes tag?
>
> It's more an ancient bug back dating back to my tenure in 2007, but here it is:
>
> Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before")

Care to send a V2 with a less meager changelog?