linux-kernel - Re: [PATCH v2 5/8] buffer: Add kernel-doc for brelse() and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240110143054.lc5t6vewsezwbcyv@localhost>
Date: Wed, 10 Jan 2024 15:30:54 +0100
From: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
To: "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc: Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	p.raghav@...sung.com
Subject: Re: [PATCH v2 5/8] buffer: Add kernel-doc for brelse() and __brelse()

> + * If all buffers on a folio have zero reference count, are clean
> + * and unlocked, and if the folio is clean and unlocked then

IIUC from your [PATCH 3/8], folio only needs to be unlocked to free the
buffers as try_to_free_buffers() will remove the dirty flag and "clean"
the folio?
So:
s/if folio is clean and unlocked/if folio is unlocked

> + * try_to_free_buffers() may strip the buffers from the folio in
> + * preparation for freeing it (sometimes, rarely, buffers are removed
> + * from a folio but it ends up not being freed, and buffers may later
> + * be reattached).
> + *
> + * Context: Any context.
> + */
>  static inline void brelse(struct buffer_head *bh)
>  {
>  	if (bh)
> -- 
> 2.43.0
>