linux-kernel - Re: [PATCH v4 4/4] mm/slub: make the description of slab_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Jan 2024 16:08:14 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: sxwjean@...com, 42.hyeyoo@...il.com, cl@...ux.com, linux-mm@...ck.org
Cc: penberg@...nel.org, rientjes@...gle.com, iamjoonsoo.kim@....com,
 roman.gushchin@...ux.dev, corbet@....net, keescook@...omium.org,
 arnd@...db.de, akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
 quic_jjohnson@...cinc.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, Xiongwei Song <xiongwei.song@...driver.com>
Subject: Re: [PATCH v4 4/4] mm/slub: make the description of slab_min_objects
 helpful in doc

On 12/15/23 04:41, sxwjean@...com wrote:
> From: Xiongwei Song <xiongwei.song@...driver.com>
> 
> There is no a value assigned to slab_min_objects by default, it always
> is 0 that is initialized by compiler if no assigned value by command line.
> min_objects is calculated based on processor numbers in calculate_order().
> For more details, see commit 9b2cd506e5f2 ("slub: Calculate min_objects
> based on number of processors.")
> 
> Signed-off-by: Xiongwei Song <xiongwei.song@...driver.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>  Documentation/mm/slub.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/mm/slub.rst b/Documentation/mm/slub.rst
> index 6579a55b7852..213491ffb66f 100644
> --- a/Documentation/mm/slub.rst
> +++ b/Documentation/mm/slub.rst
> @@ -150,7 +150,7 @@ list_lock once in a while to deal with partial slabs. That overhead is
>  governed by the order of the allocation for each slab. The allocations
>  can be influenced by kernel parameters:
>  
> -.. slab_min_objects=x		(default 4)
> +.. slab_min_objects=x		(default:automatically scaled by number of cpus)

Added a space after "default:" locally.

>  .. slab_min_order=x		(default 0)
>  .. slab_max_order=x		(default 3 (PAGE_ALLOC_COSTLY_ORDER))
>