linux-kernel - Re: [PATCH 1/1] dt-bindings: interrupt-controller: fsl,irqsteer: Add power-domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Jan 2024 16:09:07 +0000
From: Conor Dooley <conor@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Lucas Stach <l.stach@...gutronix.de>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: interrupt-controller: fsl,irqsteer: Add
 power-domains

On Wed, Jan 10, 2024 at 10:43:38AM +0100, Alexander Stein wrote:
> Some SoC like i.MX8QXP use a power-domain for this IP add it to the
> supported proerties. Fixes the dtbs_check warning:
> freescale/imx8qxp-tqma8xqp-mba8xx.dtb: irqsteer@...00000: 'power-domains'
>  does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/interrupt-controller/fsl,irqsteer.yaml#
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> 
> Notes:
>     Please note that both the board dts and the DT node for irqsteer being used,
>     are still work-in-progress.

The binding doesn't even support the imx8qxp's irqsteer yet, I think
this should be added alongside support for that SoC. Am I missing
something?

Cheers,
Conor.

> 
>  .../devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> index 20ad4ad82ad64..cb4fcd23627f6 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> @@ -42,6 +42,9 @@ properties:
>    clock-names:
>      const: ipg
>  
> +  power-domains:
> +    maxItems: 1
> +
>    interrupt-controller: true
>  
>    "#interrupt-cells":
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)