linux-kernel - Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240110-straggler-around-a53bc0a669fb@spud>
Date: Wed, 10 Jan 2024 16:23:25 +0000
From: Conor Dooley <conor@...nel.org>
To: Ninad Palsule <ninad@...ux.ibm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Guenter Roeck <linux@...ck-us.net>, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	joel@....id.au, andrew@...econstruct.com.au, peterhuewe@....de,
	jarkko@...nel.org, jgg@...pe.ca, keescook@...omium.org,
	tony.luck@...el.com, gpiccoli@...lia.com,
	johannes.holland@...ineon.com, broonie@...nel.org,
	patrick.rudolph@...ements.com, vincent@...emblay.dev,
	peteryin.openbmc@...il.com, lakshmiy@...ibm.com,
	bhelgaas@...gle.com, naresh.solanki@...ements.com,
	alexander.stein@...tq-group.com, festevam@...x.de,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	linux-integrity@...r.kernel.org, linux-hardening@...r.kernel.org,
	geissonator@...oo.com
Subject: Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

On Wed, Jan 10, 2024 at 09:54:19AM -0600, Ninad Palsule wrote:
> Hello Krzysztof,
> 
> 
> On 1/10/24 09:37, Krzysztof Kozlowski wrote:
> > On 10/01/2024 15:31, Ninad Palsule wrote:
> > > Hello Krzysztof,
> > > 
> > > 
> > > 
> > > > > > > I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad@linux.ibm.com/
> > > > > > Why did you do that? It now just adds undocumented compatibles to the
> > > > > > driver. Please, as Rob requested, work with Lukas on his series to make
> > > > > > sure that these devices are documented.
> > > > > I think krzysztof kozlowski suggested to send these patches separately:
> > > > > https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f@linaro.org/
> > > > > 
> > > > > Did I misunderstood it? Do you guys want me to include that commit again?
> > > > My comment was in DTS thread under specific DTS patch. How did you
> > > > figure out it applies to driver and bindings? This does not make sense.
> > > Sorry for the misunderstanding. Where do you want me to add driver
> > > patch? Before all DTS patches or after all DTS patches?
> > Does not matter, why do you insist on combining them with DTS? Drivers
> > and bindings are going together. DTS better separate, although depending
> > on the case can be together.
> > 
> I have combined DTS and Driver because DTS was using compatibility string
> which is not upstream yet hence I thought it is logical to send it under
> same patchset.
> 
> Conor and Rob, Do you have preference?

I'm not sure what you want from me that Krzysztof hasn't already
provided. dt-bindings and drivers usually go together, and the dts
patches are often in the same series. If you send dts separately, note
under the --- line the patches adding the binding so that the platform
maintainer knows that the compatible has not yet been documented.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)