linux-kernel - Re: [PATCH V1 2/2] PCI: Add support for "preserve-boot-config" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202401101015.Dch3YIjG-lkp@intel.com>
Date: Wed, 10 Jan 2024 10:24:45 +0800
From: kernel test robot <lkp@...el.com>
To: Vidya Sagar <vidyas@...dia.com>, lpieralisi@...nel.org, kw@...ux.com,
	robh@...nel.org, bhelgaas@...gle.com,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	will@...nel.org, frowand.list@...il.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, treding@...dia.com,
	jonathanh@...dia.com, kthota@...dia.com, mmaddireddy@...dia.com,
	vidyas@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH V1 2/2] PCI: Add support for "preserve-boot-config"
 property

Hi Vidya,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.7 next-20240109]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vidya-Sagar/dt-bindings-Add-PCIe-preserve-boot-config-property/20240109-130938
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20240109050648.1347255-3-vidyas%40nvidia.com
patch subject: [PATCH V1 2/2] PCI: Add support for "preserve-boot-config" property
config: arc-allnoconfig (https://download.01.org/0day-ci/archive/20240110/202401101015.Dch3YIjG-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240110/202401101015.Dch3YIjG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401101015.Dch3YIjG-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/of.c:271: warning: Function parameter or struct member 'node' not described in 'of_pci_check_preserve_boot_config'


vim +271 drivers/pci/of.c

   260	
   261	/**
   262	 * of_pci_check_preserve_boot_config - Return true if the boot configuration
   263	 *                                     needs to be preserved
   264	 *
   265	 * This function looks for a property called "preserve-boot-config" for a given
   266	 * PCIe controller's node and returns true if found. Having this property
   267	 * for a PCIe controller ensures that the kernel doesn't re-enumerate and
   268	 * reconfigure the BAR resources that are already done by the platform firmware.
   269	 */
   270	bool of_pci_check_preserve_boot_config(struct device_node *node)
 > 271	{
   272		return of_property_read_bool(node, "preserve-boot-config");
   273	}
   274	EXPORT_SYMBOL_GPL(of_pci_check_preserve_boot_config);
   275	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki