linux-kernel - Re: [PATCH v7 1/3] check-uapi: Introduce check-uapi.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fdf40fac-2884-426e-87f7-5cb1788616fb@quicinc.com>
Date: Wed, 10 Jan 2024 09:24:07 -0800
From: John Moon <quic_johmoo@...cinc.com>
To: Masahiro Yamada <masahiroy@...nel.org>
CC: Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers
	<ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        "Jonathan
 Corbet" <corbet@....net>, <linux-kbuild@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <kernel@...cinc.com>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>, Carlos O'Donell
	<carlos@...hat.com>,
        Randy Dunlap <rdunlap@...radead.org>, Arnd Bergmann
	<arnd@...db.de>,
        Bjorn Andersson <andersson@...nel.org>, Todd Kjos
	<tkjos@...gle.com>,
        Matthias Maennich <maennich@...gle.com>,
        Giuliano Procida
	<gprocida@...gle.com>, <kernel-team@...roid.com>,
        <libabigail@...rceware.org>, Dodji Seketeli <dodji@...hat.com>,
        Trilok Soni
	<quic_tsoni@...cinc.com>,
        Satya Durga Srinivasu Prabhala
	<quic_satyap@...cinc.com>,
        Jordan Crouse <jorcrous@...zon.com>
Subject: Re: [PATCH v7 1/3] check-uapi: Introduce check-uapi.sh

On 12/22/2023 9:50 AM, Masahiro Yamada wrote:
> On Tue, Dec 12, 2023 at 11:04 AM John Moon <quic_johmoo@...cinc.com> wrote:
> 
> The code looks OK. I think it should work as designed.
> 
> Line 197 is inconsistently indented by spaces instead of a space,
> but I can fix it up locally.
> 
> 
> I just thought requiring target commits as positional parameters
> ("check-uapi.sh treeA treeB" just like "git diff treeA treeB")
> might be intuitive, but I guess everything is specified
> by a short option is a design. I can live with that.
> 
> 
> 
> I will wait a few days, and if there is nothing more,
> I will pick up 1/3 and 2/3.
> 
> 

Thank you Masahiro! If anyone else has comments please let me know.

Cheers,
John