linux-kernel - Re: [PATCH 02/13] scripts: dtc: checks: don't warn on SPI non-peripheral child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 16:03:24 -0600
From: Rob Herring <robh+dt@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Mark Brown <broonie@...nel.org>, Jonathan Cameron <jic23@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Michael Hennerich <michael.hennerich@...log.com>, Nuno Sá <nuno.sa@...log.com>, 
	Frank Rowand <frowand.list@...il.com>, Thierry Reding <thierry.reding@...il.com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	Jonathan Corbet <corbet@....net>, linux-spi@...r.kernel.org, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/13] scripts: dtc: checks: don't warn on SPI
 non-peripheral child nodes

On Wed, Jan 10, 2024 at 1:51 PM David Lechner <dlechner@...libre.com> wrote:
>
> According to the spi-controller.yaml bindings, SPI peripheral child
> nodes match the pattern "^.*@[0-9a-f]+$".
>
> A SPI controller binding may require a child object node that is not a
> peripheral. For example, the adi,axi-spi-engine binding requires an
> "offloads" child node that is not a peripheral but rather a part of the
> controller itself.
>
> By checking for '@' in the node name, we can avoids a warnings like:
>
>     Warning (spi_bus_reg): /example-0/spi@...00000/offloads: missing or empty reg property
>
> for a binding like:
>
>     spi {
>         ...
>
>         offloads {
>             offload@0 {
>                 ...
>             };
>             ...
>         };
>
>         peripheral@0 {
>             ...
>         };
>     };
>
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---
>  scripts/dtc/checks.c | 4 ++++
>  1 file changed, 4 insertions(+)

Check the commit history. We don't take changes to kernel's dtc copy.
They must go upstream first.

Rob