linux-kernel - Re: [PATCH] kunit: device: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABVgOSmjr+8Pbz+25xN2btpd3qQOnqt8HvC9TD+QGBFPG8gS9w@mail.gmail.com>
Date: Fri, 12 Jan 2024 07:42:59 +0800
From: David Gow <davidgow@...gle.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, Shuah Khan <skhan@...uxfoundation.org>, 
	Matti Vaittinen <mazziesaccount@...il.com>, Maxime Ripard <mripard@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] kunit: device: Fix a NULL vs IS_ERR() check in init()

On Thu, 11 Jan 2024 at 02:55, Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The root_device_register() function does not return NULL, it returns
> error pointers.  Fix the check to match.
>
> Fixes: d03c720e03bd ("kunit: Add APIs for managing devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---

Thanks for catching this.

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4014 bytes)