linux-kernel - Re: Re: [PATCH] block: print symbolic error name instead of error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rqf6ufzzvmrukcaulkhmfwtjon2jwhrb2liwwimtws5r3uqmux@k2p3tccnm4sm>
Date: Fri, 12 Jan 2024 00:56:06 +0100
From: Christian Heusel <christian@...sel.eu>
To: Damien Le Moal <dlemoal@...nel.org>
Cc: Jens Axboe <axboe@...nel.dk>, Dave Chinner <dchinner@...hat.com>, 
	Jan Kara <jack@...e.cz>, Thomas Weißschuh <linux@...ssschuh.net>, 
	Christian Brauner <brauner@...nel.org>, Min Li <min15.li@...sung.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, 
	dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org
Subject: Re: Re: [PATCH] block: print symbolic error name instead of error
 code

On 24/01/12 08:37AM, Damien Le Moal wrote:
> On 1/12/24 08:15, Christian Heusel wrote:
> > -           printk(KERN_ERR " %s: p%d could not be added: %ld\n",
> > -                  disk->disk_name, p, -PTR_ERR(part));
> > +           printk(KERN_ERR " %s: p%d could not be added: %pe\n",
> > +                  disk->disk_name, p, part);
>
> pr_err() ?

If desired I can send a v2 containing another patch which refactors the
usages of printk into their respective pr_* aliases, but I wanted to
keep this consistent to the usages in rest of the file and do one change
at a time.

Cheers,
Chris


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)