linux-kernel - Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 14:39:54 +0530
From: Pranav Athreya <pranavsubbu@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Forest Bond <forest@...ttletooquiet.net>, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

My apologies, resending this as plain text.

Greg,

Thank you for reviewing my patch! Shall I amend the commit and send a
revision of the patch?
If I understand you correctly, I should remove all mention of the
mod.c file from the commit,
which will leave the new text as such:

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

Signed-off-by: Pranav Athreya <pranavsubbu@...il.com>
---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index a67757c9bb5c..be1e5180d57b 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us  125  /* 64us */

-
 /*---------------------  Export Definitions -------------------------*/

 /*---------------------  Export Variables  --------------------------*/

Yours Sincerely,

Pranav.

Yours Sincerely,

Pranav.


On Thu, Jan 11, 2024 at 2:33 PM Pranav Athreya <pranavsubbu@...il.com> wrote:
>
> Greg,
>
> Thank you for reviewing my patch! Shall I amend the commit and send a revision of the patch?
> If I understand you correctly, I should remove all mention of the .mod.c file from the commit,
> which will leave the new text as such:
>
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Pranav Athreya <pranavsubbu@...il.com>
> ---
>  drivers/staging/vt6655/rxtx.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
> index a67757c9bb5c..be1e5180d57b 100644
> --- a/drivers/staging/vt6655/rxtx.h
> +++ b/drivers/staging/vt6655/rxtx.h
> @@ -19,7 +19,6 @@
>  #define DEFAULT_MSDU_LIFETIME_RES_64us 8000 /* 64us */
>  #define DEFAULT_MGN_LIFETIME_RES_64us  125  /* 64us */
>
> -
>  /*---------------------  Export Definitions -------------------------*/
>
>  /*---------------------  Export Variables  --------------------------*/
>
>
> Yours Sincerely,
>
> Pranav.
>
>
> On Thu, Jan 11, 2024 at 12:52 PM Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
>>
>> On Thu, Jan 11, 2024 at 12:36:52PM +0530, Pranav Athreya wrote:
>> > Adhere to Linux kernel coding style.
>> >
>> > Reported by checkpatch:
>> >
>> > drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines
>> >
>> > drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines
>> > ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
>> > are included in .gitignore.
>>
>> *.mod.c files are not something that you can change, and are not in your
>> patch either:
>>
>> > Signed-off-by: Pranav Athreya <pranavsubbu@...il.com>
>> > ---
>> >  drivers/staging/vt6655/rxtx.h | 1 -
>> >  1 file changed, 1 deletion(-)
>>
>> So the text is not correct :(
>>
>> thanks,
>>
>> greg k-h