linux-kernel - Re: [PATCH] gma500: Clean up errors in psb_intel_sdvo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87edeourlv.fsf@intel.com>
Date: Thu, 11 Jan 2024 11:49:48 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: GuoHua Chen <chenguohua_716@....com>, tzimmermann@...e.de,
 airlied@...il.com, maarten.lankhorst@...ux.intel.com, daniel@...ll.ch,
 mripard@...nel.org, patrik.r.jakobsson@...il.com
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, GuoHua
 Chen <chenguohua_716@....com>
Subject: Re: [PATCH] gma500: Clean up errors in psb_intel_sdvo_regs.h

On Thu, 11 Jan 2024, GuoHua Chen <chenguohua_716@....com> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that close brace '}'
>
> Signed-off-by: GuoHua Chen <chenguohua_716@....com>
> ---
>  drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> index 600e79744d68..e358a6b1bcce 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo_regs.h
> @@ -666,7 +666,7 @@ struct psb_intel_sdvo_enhancement_limits_reply {
>  #define SDVO_CMD_SET_TV_LUMA_FILTER			0x79
>  struct psb_intel_sdvo_enhancements_arg {
>      u16 value;
> -}__attribute__((packed));
> +} __attribute__((packed));

__packed is preferred over __attribute__((packed)) anyway...

BR,
Jani.



>  
>  #define SDVO_CMD_GET_DOT_CRAWL				0x70
>  #define SDVO_CMD_SET_DOT_CRAWL				0x71

-- 
Jani Nikula, Intel