linux-kernel - Re: [PATCH v1] Bluetooth: btnxpuart: Disable Power Save feature on startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f776426-b01f-4204-b508-485d3f13e933@molgen.mpg.de>
Date: Thu, 11 Jan 2024 11:33:44 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
Cc: marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
 amitkumar.karwar@....com, linux-bluetooth@...r.kernel.org,
 linux-kernel@...r.kernel.org, sherry.sun@....com, rohit.fule@....com
Subject: Re: [PATCH v1] Bluetooth: btnxpuart: Disable Power Save feature on
 startup

Dear Neeraj,


Thank you for your patch. Some nits below.

Am 11.01.24 um 09:06 schrieb Neeraj Sanjay Kale:
> This sets the default power save mode setting to enabled.

This contradicts the commit message summary, which says “Disable”.

> The power save feature is now stable and stress test issues,
> such as the TX timeout error, has been resolved.

have been

Please reference one commit, that fixed this.

> With this setting, the driver will send the vendor command
> to FW at startup, to enable power save feature.
> User can disable this feature using the following vendor
> command:
> hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)

It would help me, if you used the full 75 characters per line for commit 
messages, and would not break the line after every sentence. If a 
paragraph makes sense, please separate it by a  blank line.

> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> ---
>   drivers/bluetooth/btnxpuart.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
> index 7f88b6f52f26..42e929f0d141 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -281,7 +281,7 @@ static u8 crc8_table[CRC8_TABLE_SIZE];
>   
>   /* Default configurations */
>   #define DEFAULT_H2C_WAKEUP_MODE	WAKEUP_METHOD_BREAK
> -#define DEFAULT_PS_MODE		PS_MODE_DISABLE
> +#define DEFAULT_PS_MODE		PS_MODE_ENABLE
>   #define FW_INIT_BAUDRATE	HCI_NXP_PRI_BAUDRATE
>   
>   static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul