lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20240111112751.15810-1-chenxb_99091@126.com>
Date: Thu, 11 Jan 2024 11:27:51 +0000
From: XueBing Chen <chenxb_99091@....com>
To: jejb@...ux.ibm.com,
	aacraid@...rosemi.com,
	martin.petersen@...cle.com
Cc: linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	XueBing Chen <chenxb_99091@....com>
Subject: [PATCH] scsi: aacraid: Clean up errors in commctrl.c

Fix the following errors reported by checkpatch:

ERROR: "foo* bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: space required before the open parenthesis '('

Signed-off-by: XueBing Chen <chenxb_99091@....com>
---
 drivers/scsi/aacraid/commctrl.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index e7cc927ed952..049b88030571 100644
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -397,12 +397,12 @@ int aac_close_fib_context(struct aac_dev * dev, struct aac_fib_context * fibctx)
  *	This routine will close down the fibctx passed in from the user.
  */
 
-static int close_getadapter_fib(struct aac_dev * dev, void __user *arg)
+static int close_getadapter_fib(struct aac_dev *dev, void __user *arg)
 {
 	struct aac_fib_context *fibctx;
 	int status;
 	unsigned long flags;
-	struct list_head * entry;
+	struct list_head *entry;
 
 	/*
 	 *	Verify that the HANDLE passed in was a valid AdapterFibContext
@@ -414,7 +414,7 @@ static int close_getadapter_fib(struct aac_dev * dev, void __user *arg)
 	entry = dev->fib_list.next;
 	fibctx = NULL;
 
-	while(entry != &dev->fib_list) {
+	while (entry != &dev->fib_list) {
 		fibctx = list_entry(entry, struct aac_fib_context, next);
 		/*
 		 *	Extract the fibctx from the input parameters
@@ -428,7 +428,7 @@ static int close_getadapter_fib(struct aac_dev * dev, void __user *arg)
 	if (!fibctx)
 		return 0; /* Already gone */
 
-	if((fibctx->type != FSAFS_NTC_GET_ADAPTER_FIB_CONTEXT) ||
+	if ((fibctx->type != FSAFS_NTC_GET_ADAPTER_FIB_CONTEXT) ||
 		 (fibctx->size != sizeof(struct aac_fib_context)))
 		return -EINVAL;
 	spin_lock_irqsave(&dev->fib_lock, flags);
@@ -476,9 +476,9 @@ static int check_revision(struct aac_dev *dev, void __user *arg)
  *	@dev:	adapter is being processed
  *	@arg:	arguments to the send call
  */
-static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
+static int aac_send_raw_srb(struct aac_dev *dev, void __user *arg)
 {
-	struct fib* srbfib;
+	struct fib *srbfib;
 	int status;
 	struct aac_srb *srbcmd = NULL;
 	struct aac_hba_cmd_req *hbacmd = NULL;
@@ -505,7 +505,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
 		dprintk((KERN_DEBUG"aacraid: send raw srb -EBUSY\n"));
 		return -EBUSY;
 	}
-	if (!capable(CAP_SYS_ADMIN)){
+	if (!capable(CAP_SYS_ADMIN)) {
 		dprintk((KERN_DEBUG"aacraid: No permission to send raw srb\n"));
 		return -EPERM;
 	}
-- 
2.17.1


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ