linux-kernel - Re: [PATCH] mfd: twl: Clean up errors in twl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 11:38:00 +0000
From: Lee Jones <lee@...nel.org>
To: chenxuebing <chenxb_99091@....com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: twl: Clean up errors in twl.h

The subject needs to be improved.

Succinctly explain what you're doing.

On Thu, 11 Jan 2024, chenxuebing wrote:

> Fix the following errors reported by checkpatch:
> 
> ERROR: space prohibited after that open parenthesis '('
> ERROR: open brace '{' following function definitions go on the next line
> 
> Signed-off-by: chenxuebing <chenxb_99091@....com>

Is this your first or last name, or both?

> ---
>  include/linux/mfd/mcp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mfd/mcp.h b/include/linux/mfd/mcp.h
> index fd5cafc77e8a..ed56c67bbbc7 100644
> --- a/include/linux/mfd/mcp.h
> +++ b/include/linux/mfd/mcp.h
> @@ -53,7 +53,7 @@ int mcp_driver_register(struct mcp_driver *);
>  void mcp_driver_unregister(struct mcp_driver *);
>  
>  #define mcp_get_drvdata(mcp)	dev_get_drvdata(&(mcp)->attached_device)
> -#define mcp_set_drvdata(mcp,d)	dev_set_drvdata(&(mcp)->attached_device, d)
> +#define mcp_set_drvdata(mcp, d)	dev_set_drvdata(&(mcp)->attached_device, d)

The code is fine, obviously.

>  static inline void *mcp_priv(struct mcp *mcp)
>  {
> -- 
> 2.17.1
> 

-- 
Lee Jones [李琼斯]