linux-kernel - Re: [PATCH] MIPS: Alchemy: Fix an out-of-bound access in db1200_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 12:51:25 +0100
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: vkoul@...nel.org, jiaheng.fan@....com, peng.ma@....com,
	wen.he_1@....com, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: Fix an out-of-bound access in
 db1200_dev_setup()

On Wed, Jan 10, 2024 at 07:07:36PM +0100, Christophe JAILLET wrote:
> When calling spi_register_board_info(), we should pass the number of
> elements in 'db1200_spi_devs', not 'db1200_i2c_devs'.
> 
> Fixes: 63323ec54a7e ("MIPS: Alchemy: Extended DB1200 board support.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only
> ---
>  arch/mips/alchemy/devboards/db1200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/alchemy/devboards/db1200.c b/arch/mips/alchemy/devboards/db1200.c
> index f521874ebb07..67f067706af2 100644
> --- a/arch/mips/alchemy/devboards/db1200.c
> +++ b/arch/mips/alchemy/devboards/db1200.c
> @@ -847,7 +847,7 @@ int __init db1200_dev_setup(void)
>  	i2c_register_board_info(0, db1200_i2c_devs,
>  				ARRAY_SIZE(db1200_i2c_devs));
>  	spi_register_board_info(db1200_spi_devs,
> -				ARRAY_SIZE(db1200_i2c_devs));
> +				ARRAY_SIZE(db1200_spi_devs));
>  
>  	/* SWITCHES:	S6.8 I2C/SPI selector  (OFF=I2C	 ON=SPI)
>  	 *		S6.7 AC97/I2S selector (OFF=AC97 ON=I2S)
> -- 
> 2.34.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]