linux-kernel - Re: [PATCH] platform/x86: silicom-platform: clean up a check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 15:34:56 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Hans de Goede <hdegoede@...hat.com>, Henry Shi <henryshi2018@...il.com>,
	platform-driver-x86@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] platform/x86: silicom-platform: clean up a check

On Thu, Jan 11, 2024 at 01:56:28PM +0200, Ilpo Järvinen wrote:
> On Wed, 10 Jan 2024, Dan Carpenter wrote:
> 
> > "value" is either non-zero, or zero.  There isn't a third option.
> > Delete the unnecessary code.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  drivers/platform/x86/silicom-platform.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/silicom-platform.c b/drivers/platform/x86/silicom-platform.c
> > index 6ce43ccb3112..5cac698bf98d 100644
> > --- a/drivers/platform/x86/silicom-platform.c
> > +++ b/drivers/platform/x86/silicom-platform.c
> > @@ -258,10 +258,8 @@ static void silicom_gpio_set(struct gpio_chip *gc,
> >  
> >  	if (value)
> >  		silicom_mec_port_set(channel, 0);
> > -	else if (value == 0)
> > -		silicom_mec_port_set(channel, 1);
> >  	else
> > -		pr_err("Wrong argument value: %d\n", value);
> > +		silicom_mec_port_set(channel, 1);
> 
> This covers both cases without if:
> 
> 	silicom_mec_port_set(channel, !value);
> 

True.  Let me resend it that way.

regards,
dan carpenter