linux-kernel - 回复: [PATCH v2] selftests/move_mount_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c398076d4624691a97766bad168d975@h3c.com>
Date: Thu, 11 Jan 2024 02:25:03 +0000
From: Huyadi <hu.yadi@....com>
To: Mickaël Salaün <mic@...ikod.net>
CC: "jmorris@...ei.org" <jmorris@...ei.org>,
        "serge@...lyn.com"
	<serge@...lyn.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
        "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-security-module@...r.kernel.org"
	<linux-security-module@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>,
        "514118380@...com" <514118380@...com>
Subject: 回复: [PATCH v2] selftests/move_mount_set_group:Make tests build with old libc


>On Wed, Jan 10, 2024 at 03:29:01PM +0800, Hu Yadi wrote:
>> From: "Hu.Yadi" <hu.yadi@....com>
>> 
>> Replace SYS_<syscall> with __NR_<syscall>.  Using the __NR_<syscall> 
>> notation, provided by UAPI, is useful to build tests on systems 
>> without the SYS_<syscall> definitions.
>
>This looks a lot like that...
>https://git.kernel.org/stable/c/87129ef13603ae46c82bcd09eed948acf0506dbb

Yes, I picked up comments from above commit in order for consistent,
I would send v3 patch if it is inappropriate. 

>> 
>> Replace SYS_move_mount with __NR_move_mount
>> 
>> Signed-off-by: Hu.Yadi <hu.yadi@....com> Suggested-by:Jiao 
>> <jiaoxupo@....com> Reviewed-by:Berlin <berlin@....com>
>> ---
>> Changes v1 -> v2:
>>  - Fix mail of Suggested-by and Reviewed-by
>> 
>>  .../move_mount_set_group/move_mount_set_group_test.c          | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git 
>> a/tools/testing/selftests/move_mount_set_group/move_mount_set_group_te
>> st.c 
>> b/tools/testing/selftests/move_mount_set_group/move_mount_set_group_te
>> st.c index 50ed5d475dd1..bcf51d785a37 100644
>> --- 
>> a/tools/testing/selftests/move_mount_set_group/move_mount_set_group_te
>> st.c
>> +++ b/tools/testing/selftests/move_mount_set_group/move_mount_set_grou
>> +++ p_test.c
>> @@ -218,7 +218,7 @@ static bool move_mount_set_group_supported(void)
>>  	if (mount(NULL, SET_GROUP_FROM, NULL, MS_SHARED, 0))
>>  		return -1;
>>  
>> -	ret = syscall(SYS_move_mount, AT_FDCWD, SET_GROUP_FROM,
>> +	ret = syscall(__NR_move_mount, AT_FDCWD, SET_GROUP_FROM,
>>  		      AT_FDCWD, SET_GROUP_TO, MOVE_MOUNT_SET_GROUP);
>>  	umount2("/tmp", MNT_DETACH);
>>  
>> @@ -363,7 +363,7 @@ TEST_F(move_mount_set_group, complex_sharing_copying)
>>  		       CLONE_VM | CLONE_FILES); ASSERT_GT(pid, 0);
>>  	ASSERT_EQ(wait_for_pid(pid), 0);
>>  
>> -	ASSERT_EQ(syscall(SYS_move_mount, ca_from.mntfd, "",
>> +	ASSERT_EQ(syscall(__NR_move_mount, ca_from.mntfd, "",
>>  			  ca_to.mntfd, "", MOVE_MOUNT_SET_GROUP
>>  			  | MOVE_MOUNT_F_EMPTY_PATH | MOVE_MOUNT_T_EMPTY_PATH),
>>  		  0);
>> --
>> 2.23.0
>>