linux-kernel - Re: [PATCH 1/2] gpio: vf610: add support to DT 'ngpios' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYvXEBPWgFYEgF5kx=JLjSadU38UUUPPNOg+K46ff2kCw@mail.gmail.com>
Date: Thu, 11 Jan 2024 15:22:59 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Hector Palacios <hector.palacios@...i.com>
Cc: bartosz.golaszewski@...aro.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, haibo.chen@....com, peng.fan@....com
Subject: Re: [PATCH 1/2] gpio: vf610: add support to DT 'ngpios' property

On Thu, Jan 11, 2024 at 2:20 PM Hector Palacios
<hector.palacios@...i.com> wrote:

> Default to hardcoded VF610_GPIO_PER_PORT (32 pins) but allow optional
> generic 'ngpios' property to be specified from the device tree.
>
> Signed-off-by: Hector Palacios <hector.palacios@...i.com>

Looks correct to me.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

NB: this only makes sense when you use GPIOs 0...n where n < 31.

We also have the .valid_mask and .init_valid_mask() callback if
you want to mask out GPIOs in the middle or beginning or so.

Yours,
Linus Walleij

Yours,
Linus Walleij