linux-kernel - Re: [PATCH] drm/edid: Clean up errors in drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 16:50:05 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: chenxuebing <chenxb_99091@....com>, daniel@...ll.ch, airlied@...il.com,
 mripard@...nel.org, maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 chenxuebing <chenxb_99091@....com>
Subject: Re: [PATCH] drm/edid: Clean up errors in drm_edid.h

On Thu, 11 Jan 2024, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
> On Thu, 11 Jan 2024, chenxuebing <chenxb_99091@....com> wrote:
>> Fix the following errors reported by checkpatch:
>>
>> ERROR: do not use assignment in if condition
>>
>> Signed-off-by: chenxuebing <chenxb_99091@....com>
>
> Reviewed-by: Jani Nikula <jani.nikula@...el.com>

And pushed to drm-misc-next, thanks for the patch.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/drm_edid.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index 69c68804023f..9bcaf76f10fc 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -3611,7 +3611,8 @@ static bool mode_in_range(const struct drm_display_mode *mode,
>>  	if (!mode_in_vsync_range(mode, edid, t))
>>  		return false;
>>  
>> -	if ((max_clock = range_pixel_clock(edid, t)))
>> +	max_clock = range_pixel_clock(edid, t);
>> +	if (max_clock)
>>  		if (mode->clock > max_clock)
>>  			return false;

-- 
Jani Nikula, Intel