linux-kernel - Re: [PATCH] riscv: vector: Check SR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 23:16:06 +0800
From: Andy Chiu <andy.chiu@...ive.com>
To: patchwork-bot+linux-riscv@...nel.org, Palmer Dabbelt <palmer@...belt.com>
Cc: Song Shuai <songshuaishuai@...ylab.org>, linux-riscv@...ts.infradead.org, 
	paul.walmsley@...ive.com, aou@...s.berkeley.edu, greentime.hu@...ive.com, 
	conor.dooley@...rochip.com, guoren@...nel.org, bjorn@...osinc.com, 
	xiao.w.wang@...el.com, heiko@...ech.de, ruinland.tsai@...ive.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: vector: Check SR_SD before saving vstate

Hi Palmer,

On Thu, Jan 11, 2024 at 10:50 PM <patchwork-bot+linux-riscv@...nel.org> wrote:
>
> Hello:
>
> This patch was applied to riscv/linux.git (for-next)

IIUC the conclusion for this thread is not to check SD bit for either
vector or fpu. The patch for this was sent together with the
kernel-mode vector series and has been reviewed-by both Song and Guo.

> by Palmer Dabbelt <palmer@...osinc.com>:
>
> On Thu, 21 Dec 2023 15:04:49 +0800 you wrote:
> > The SD bit summarizes the dirty states of FS, VS, or XS fields,
> > providing a "fast check" before saving fstate or vstate.
> >
> > Let __switch_to_vector() check SD bit as __switch_to_fpu() does.
> >
> > Fixes: 3a2df6323def ("riscv: Add task switch support for vector")
> > Signed-off-by: Song Shuai <songshuaishuai@...ylab.org>
> >
> > [...]
>
> Here is the summary with links:
>   - riscv: vector: Check SR_SD before saving vstate
>     https://git.kernel.org/riscv/c/e1b76bc00ed1
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
>

Please let me know if I missed anything.

Thanks,
Andy