linux-kernel - Re: [PATCH] nvmem: core: add fixed-layout declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 16:41:45 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: srinivas.kandagatla@...aro.org, michael@...le.cc, rafal@...ecki.pl,
 robh@...nel.org, linux-kernel@...r.kernel.org,
 bsp-development.geo@...ca-geosystems.com, gregkh@...uxfoundation.org,
 luca.ceresoli@...tlin.com
Subject: Re: [PATCH] nvmem: core: add fixed-layout declaration

Hi Catalin,

catalin.popescu@...ca-geosystems.com wrote on Thu, 11 Jan 2024 16:28:49
+0100:

> Declare fixed-layout as a supported layout and use add_cells
> callback to parse the cells. This adds consistency over layouts
> parsing as fixed-layout parsing is now handled in the same way
> than others nvmem layouts.

Thanks for submitting a new version, next time you'll need to increase the version number in the title (use git-send-email -v <version>) and also please append a changelog below the three dashes...

> 
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
> ---

..here.

Also, I think you should rebase on top of -rc1 when it will be out (in
less than two weeks) because I believe the code snipped below will no
longer apply...

>  drivers/nvmem/core.c | 24 +++++++++++++++++-------
>  1 file changed, 17 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 608b352a7d91..d7f34cbea34b 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -746,7 +746,9 @@ static int nvmem_add_cells_from_legacy_of(struct nvmem_device *nvmem)
>  	return nvmem_add_cells_from_dt(nvmem, nvmem->dev.of_node);
>  }
>  
> -static int nvmem_add_cells_from_fixed_layout(struct nvmem_device *nvmem)
> +static int nvmem_add_cells_from_fixed_layout(struct device *dev,
> +					     struct nvmem_device *nvmem,
> +					     struct nvmem_layout *layout)

.. this one.

Otherwise LGTM.

Thanks,
Miquèl