linux-kernel - Re: [PATCH] dmaengine: fsl-edma: fix Makefile logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 17:23:03 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Frank Li" <Frank.li@....com>
Cc: "Arnd Bergmann" <arnd@...nel.org>, "Vinod Koul" <vkoul@...nel.org>,
 "Peng Fan" <peng.fan@....com>, "Fabio Estevam" <festevam@...x.de>,
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH] dmaengine: fsl-edma: fix Makefile logic

On Thu, Jan 11, 2024, at 17:09, Frank Li wrote:
> On Thu, Jan 11, 2024 at 07:23:34AM +0100, Arnd Bergmann wrote:
>> On Thu, Jan 11, 2024, at 01:02, Frank Li wrote:
>
> It should be better link into same module because some debugfs and trace
> improvement are on my TODO list. Export symbols will make more unnessary
> complex.

Ok, I'll see what I can come up with

> Or simple exclude MCF_EDMA by change Kconfig
>
> config MCF_EDMA                                                            
>         tristate "Freescale eDMA engine support, ColdFire mcf5441x SoCs"   
>         depends on !FSL_EDMA
> 		   ^^^^^
> 	depends on M5441x || COMPILE_TEST 

This does not actually prevent building both as modules, it
only enforces that you can't have them both enabled if one
of them is built-in.

     Arnd