linux-kernel - Re: [PATCH] hrtimer.c : Remove redundant thread state settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877ckfkefv.ffs@tglx>
Date: Thu, 11 Jan 2024 17:44:20 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Lizhe <sensor1010@....com>, ilpo.jarvinen@...ux.intel.com
Cc: linux-kernel@...r.kernel.org, Lizhe <sensor1010@....com>
Subject: Re: [PATCH] hrtimer.c : Remove redundant thread state settings

On Wed, Jan 10 2024 at 06:13, Lizhe wrote:
> After a thread is awakened, its state is already task_running

That's correct, but please look at hrtimer_wakeup() and the conditional
schedule() invocation in schedule_hrtimeout_range_clock(). You break the
guarantee that this function returns with task state == TASK_RUNNING.

Thanks,

        tglx