linux-kernel - Re: [PATCH v11 6/8] iommufd/selftest: Add coverage for IOMMU_HWPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Jan 2024 12:54:35 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: Yi Liu <yi.l.liu@...el.com>, joro@...tes.org,
	alex.williamson@...hat.com, kevin.tian@...el.com,
	robin.murphy@....com, baolu.lu@...ux.intel.com, cohuck@...hat.com,
	eric.auger@...hat.com, kvm@...r.kernel.org, mjrosato@...ux.ibm.com,
	chao.p.peng@...ux.intel.com, yi.y.sun@...ux.intel.com,
	peterx@...hat.com, jasowang@...hat.com,
	shameerali.kolothum.thodi@...wei.com, lulu@...hat.com,
	suravee.suthikulpanit@....com, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	zhenzhong.duan@...el.com, joao.m.martins@...cle.com,
	xin.zeng@...el.com, yan.y.zhao@...el.com, j.granados@...sung.com,
	binbin.wu@...ux.intel.com
Subject: Re: [PATCH v11 6/8] iommufd/selftest: Add coverage for
 IOMMU_HWPT_INVALIDATE ioctl

On Thu, Jan 11, 2024 at 08:50:45AM -0800, Nicolin Chen wrote:
> On Wed, Jan 10, 2024 at 08:10:13PM -0800, Yi Liu wrote:
> > +#define test_cmd_hwpt_invalidate(hwpt_id, reqs, data_type, lreq, nreqs)        \
> > +       ({                                                                    \
> > +               ASSERT_EQ(0,                                                  \
> > +                         _test_cmd_hwpt_invalidate(self->fd, hwpt_id, reqs,  \
> > +                                                   data_type,                 \
> > +                                                   lreq, nreqs));            \
> > +       })
> > +#define test_err_hwpt_invalidate(_errno, hwpt_id, reqs, data_type, lreq,    \
> > +                                nreqs)                                    \
> > +       ({                                                                 \
> > +               EXPECT_ERRNO(_errno,                                       \
> > +                            _test_cmd_hwpt_invalidate(self->fd, hwpt_id,  \
> > +                                                      reqs, data_type,     \
> > +                                                      lreq, nreqs));      \
> > +       })
> 
> Nit: spaces at the end of the four lines above that have string
> "data_type" are all misaligned, probably because of the previous
> replacement of "req_type".

I will fix it

Jason