linux-kernel - Re: [PATCH v3] Documentation: KUnit: Update the instructions on how to test static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 12:34:25 +0800
From: David Gow <davidgow@...gle.com>
To: Arthur Grillo <arthurgrillo@...eup.net>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, Jonathan Corbet <corbet@....net>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Documentation: KUnit: Update the instructions on how
 to test static functions

On Thu, 11 Jan 2024 at 01:39, Arthur Grillo <arthurgrillo@...eup.net> wrote:
>
> Now that we have the VISIBLE_IF_KUNIT and EXPORT_SYMBOL_IF_KUNIT macros,
> update the instructions to recommend this way of testing static
> functions.
>
> Signed-off-by: Arthur Grillo <arthurgrillo@...eup.net>
> ---
> Changes in v3:
> - Maintain the old '#include' way
> - Link to v2: https://lore.kernel.org/r/20240108-kunit-doc-export-v2-1-8f2dd3395fed@riseup.net
>
> Changes in v2:
> - Fix #if condition
> - Link to v1: https://lore.kernel.org/r/20240108-kunit-doc-export-v1-1-119368df0d96@riseup.net
> ---

This looks good, thanks!

Reviewed-by: David Gow <davidgow@...gle.com>

We may try to add some more reference documentation for the
visibility.h header later on, but this example is probably more useful
anyway.

Cheers,
-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4014 bytes)