linux-kernel - Re: [PATCH] KEYS: include header for EINVAL definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8ad036a-7d65-4dbe-8c87-f569e54d7a57@hpe.com>
Date: Fri, 12 Jan 2024 13:59:39 +0800
From: Clay Chang <clayc@....com>
To: Jarkko Sakkinen <jarkko@...nel.org>, <keyrings@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <dhowells@...hat.com>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>
Subject: Re: [PATCH] KEYS: include header for EINVAL definition

Hi Jarkko,

Yes, I have. I am working on an OpenBMC project and the kernel .config was generated by merging several config fragments. In one experiment where the CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not presented, I got a EINVAL undeclared compilation error.

Do you want me to show the full .config here?

Thanks,
Clay

On 2024/1/11 3:54 AM, Jarkko Sakkinen wrote:
> On Tue Jan 9, 2024 at 4:10 AM EET, Clay Chang wrote:
>> Hi Jarkko,
>>
>> The issue was found when crypto/public_key.h was included, but
>> CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled. If
>> CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled, the
>> public_key_verify_signature simply returned -EINVAL, which was not
>> declared without linux/errno.h being included.
>>
>> Thanks,
>> Clay
> 
> Do you have .config to verify this?
> 
> BR, Jarkko