linux-kernel - [PATCH] vfio/platform: Remove unnecessary free in vfio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240112064107.137384-1-chentao@kylinos.cn>
Date: Fri, 12 Jan 2024 14:41:07 +0800
From: Kunwu Chan <chentao@...inos.cn>
To: eric.auger@...hat.com,
	alex.williamson@...hat.com
Cc: a.motakis@...tualopensystems.com,
	b.reynal@...tualopensystems.com,
	kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Kunwu Chan <chentao@...inos.cn>
Subject: [PATCH] vfio/platform: Remove unnecessary free in vfio_set_trigger

commit 57f972e2b341 ("vfio/platform: trigger an interrupt via eventfd")
add 'name' as member for vfio_platform_irq,it's initialed by kasprintf,
so there is no need to free it before initializing.

Fixes: 57f972e2b341 ("vfio/platform: trigger an interrupt via eventfd")
Signed-off-by: Kunwu Chan <chentao@...inos.cn>
---
 drivers/vfio/platform/vfio_platform_irq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c
index 61a1bfb68ac7..5e3fd1926366 100644
--- a/drivers/vfio/platform/vfio_platform_irq.c
+++ b/drivers/vfio/platform/vfio_platform_irq.c
@@ -179,7 +179,6 @@ static int vfio_set_trigger(struct vfio_platform_device *vdev, int index,
 	if (irq->trigger) {
 		irq_clear_status_flags(irq->hwirq, IRQ_NOAUTOEN);
 		free_irq(irq->hwirq, irq);
-		kfree(irq->name);
 		eventfd_ctx_put(irq->trigger);
 		irq->trigger = NULL;
 	}
-- 
2.39.2