linux-kernel - Re: [PATCH v2 3/3] mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c789b3a-1a2c-47a4-b8f7-191bb13f060f@linaro.org>
Date: Fri, 12 Jan 2024 08:24:28 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ben Levinsky <ben.levinsky@....com>, jassisinghbrar@...il.com,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 michal.simek@....com, shubhrajyoti.datta@....com, jaswinder.singh@...aro.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] mailbox: zynqmp: Enable Bufferless IPI usage on
 Versal-based SOC's

On 11/01/2024 18:22, Ben Levinsky wrote:
>  /**
>   * zynqmp_ipi_free_mboxes - Free IPI mailboxes devices
>   *
> @@ -748,6 +861,9 @@ static const struct of_device_id zynqmp_ipi_of_match[] = {
>  	{ .compatible = "xlnx,zynqmp-ipi-mailbox",
>  	  .data = &zynqmp_ipi_setup,
>  	},
> +	{ .compatible = "xlnx,versal-ipi-mailbox",

Not documented.

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.


Best regards,
Krzysztof