linux-kernel - Re: [PATCH v4] arm64: dts: qcom: qcs6490-idp: Add definition for three LEDs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f14bff5-4f3e-426b-b81d-006da061af1e@linaro.org>
Date: Fri, 12 Jan 2024 08:44:40 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: quic_huliu@...cinc.com, Andy Gross <agross@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] arm64: dts: qcom: qcs6490-idp: Add definition for
 three LEDs.

On 12/01/2024 04:05, Hui Liu via B4 Relay wrote:
> From: Hui Liu <quic_huliu@...cinc.com>
> 
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
> 
> Signed-off-by: Hui Liu <quic_huliu@...cinc.com>
> ---
> Changes in v4:
> - Removed "label" definition and added "function" definition.

You did not test your patch before sending.

Subject is still wrong. Also, it still has unnecessary full stop. Drop it.

Best regards,
Krzysztof