linux-kernel - RE: [PATCH v3 1/2] KVM: VMX: Cleanup VMX basic information defines and usages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 09:51:04 +0000
From: "Li, Xin3" <xin3.li@...el.com>
To: Xin Li <xin@...or.com>, "Huang, Kai" <kai.huang@...el.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "Yang, Weijiang" <weijiang.yang@...el.com>, "Christopherson,, Sean"
	<seanjc@...gle.com>, "x86@...nel.org" <x86@...nel.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "hpa@...or.com"
	<hpa@...or.com>, "mingo@...hat.com" <mingo@...hat.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "bp@...en8.de" <bp@...en8.de>, "pbonzini@...hat.com"
	<pbonzini@...hat.com>
Subject: RE: [PATCH v3 1/2] KVM: VMX: Cleanup VMX basic information defines
 and usages

> >> @@ -6964,7 +6975,7 @@ static void nested_vmx_setup_basic(struct
> nested_vmx_msrs *msrs)
> >>   		VMCS12_REVISION |
> >>   		VMX_BASIC_TRUE_CTLS |
> >>   		((u64)VMCS12_SIZE << VMX_BASIC_VMCS_SIZE_SHIFT) |
> >> -		(VMX_BASIC_MEM_TYPE_WB <<
> VMX_BASIC_MEM_TYPE_SHIFT);
> >> +		(MEM_TYPE_WB << VMX_BASIC_MEM_TYPE_SHIFT);
> >>
> >
> > ... here, we can remove the two _SHIFT but define below instead:
> >
> >    #define VMX_BASIC_VMCS12_SIZE	((u64)VMCS12_SIZE << 32)
> >    #define VMX_BASIC_MEM_TYPE_WB	(MEM_TYPE_WB << 50)
> 
> I personally don't like such names, unless we can name them in a better way.
> 
> >
> > And use above two macros in nested_vmx_setup_basic()?

A second thought on this, I agree this is better.  And I will post v4.

Thanks!
    Xin