linux-kernel - Re: [PATCH printk v3 01/14] printk: nbcon: Relocate 32bit seq macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZaEQ8KMPXcAXC8_p@alley>
Date: Fri, 12 Jan 2024 11:14:08 +0100
From: Petr Mladek <pmladek@...e.com>
To: John Ogness <john.ogness@...utronix.de>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH printk v3 01/14] printk: nbcon: Relocate 32bit seq macros

On Thu 2023-12-14 22:47:48, John Ogness wrote:
> The macros __seq_to_nbcon_seq() and __nbcon_seq_to_seq() are
> used to provide support for atomic handling of sequence numbers
> on 32bit systems. Until now this was only used by nbcon.c,
> which is why they were located in nbcon.c and include nbcon in
> the name.
> 
> In a follow-up commit this functionality is also needed by
> printk_ringbuffer. Rather than duplicating the functionality,
> relocate the macros to printk_ringbuffer.h.
> 
> Also, since the macros will be no longer nbcon-specific, rename
> them to __u64seq_to_ulseq() and __ulseq_to_u64seq().
> 
> This does not result in any functional change.
> 
> Signed-off-by: John Ogness <john.ogness@...utronix.de>

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr