linux-kernel - Re: [RESEND PATCH v2] acpi: Use access_width over register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf1a84e0-bf88-41a1-ad0c-4270aaa5d3aa@linux.microsoft.com>
Date: Fri, 12 Jan 2024 06:19:31 -0800
From: Jarred White <jarredwhite@...ux.microsoft.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Len Brown <lenb@...nel.org>, "open list:ACPI"
 <linux-acpi@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v2] acpi: Use access_width over register_width for
 system memory accesses

On 12/22/2023 4:00 PM, Easwar Hariharan wrote:
>  >> @@ -784,7 +792,8 @@ int acpi_cppc_processor_probe(struct 
> acpi_processor *pr)
>  >>                                                          goto out_free;
>  >>                                          }
>  >>
>  >> -                                       addr = 
> ioremap(gas_t->address, gas_t->bit_width/8);
>  >> +                                       access_width = 
> ACCESS_WIDTH_TO_BITS(gas_t) / 8;
>  >
>  > What would happen if the platform firmware incorrectly provided
>  > reg->access_witdh == 0?
>  >
> 

Unfortunately, we have no hardware platform with this configuration to 
test with. What is the level of concern here? Were there previous 
changes that raised this similar concerns?

Thanks,
Jarred