linux-kernel - 回复: [PATCH v2 08/13] staging: media: starfive: Add for StarFive ISP 3A SC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 01:30:33 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Matthias Brugger <matthias.bgg@...il.com>, Hans
 Verkuil <hverkuil-cisco@...all.nl>, Ming Qian <ming.qian@....com>, Laurent
 Pinchart <laurent.pinchart@...asonboard.com>, Nicolas Dufresne
	<nicolas.dufresne@...labora.com>, Benjamin Gaignard
	<benjamin.gaignard@...labora.com>, Tomi Valkeinen
	<tomi.valkeinen+renesas@...asonboard.com>, Mingjia Zhang
	<mingjia.zhang@...iatek.com>, Jack Zhu <jack.zhu@...rfivetech.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>
Subject:
 回复: [PATCH v2 08/13] staging: media: starfive: Add for StarFive ISP 3A SC

Hi, Dan

Thanks for your comment.
 
> On Thu, Jan 11, 2024 at 12:41:15AM -0800, Changhuang Liang wrote:
> > Register ISP 3A "capture_scd" video device to receive statistics
> > collection data.
> >
> > Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> > ---
[...]
> > @@ -150,6 +151,13 @@ static int stfcamss_register_devs(struct stfcamss
> > *stfcamss)
> >
> >  	cap_yuv->video.source_subdev = &isp_dev->subdev;
> >
> > +	ret = media_create_pad_link(&isp_dev->subdev.entity,
> STF_ISP_PAD_SRC_SCD,
> > +				    &cap_scd->video.vdev.entity, 0, 0);
> > +	if (ret)
> > +		goto err_cap_unregister;
> > +
> 
> Don't we need to do something like
> 
> 	media_entity_remove_links(&cap_yuv->video.vdev.entity);
> 
> as part of the cleanup?  Also where do we clean up this new call to
> media_create_pad_link() in the unregister process?
> 

Yes, I will call it in next version. Original code is missing the cleanup
process, add I will add it too.

> > +	cap_scd->video.source_subdev = &isp_dev->subdev;
> > +
> >  	return ret;
> >
> >  err_cap_unregister:
> 
> regards,
> dan carpenter

regards,
Changhuang