linux-kernel - Re: [PATCH] thermal/debugfs: Unlock on error path in thermal_debug_tz_trip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 15:56:31 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] thermal/debugfs: Unlock on error path in thermal_debug_tz_trip_up()

On Fri, Jan 12, 2024 at 3:30 PM Dan Carpenter <dan.carpenter@...aroorg> wrote:
>
> Add a missing mutex_unlock(&thermal_dbg->lock) to this error path.
>
> Fixes: 4731c8f16a0e ("thermal/debugfs: Add thermal debugfs information for mitigation episodes")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/thermal/thermal_debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_debugfs.c b/drivers/thermal/thermal_debugfs.c
> index a3fa09235da1..a3f06029fc54 100644
> --- a/drivers/thermal/thermal_debugfs.c
> +++ b/drivers/thermal/thermal_debugfs.c
> @@ -591,7 +591,7 @@ void thermal_debug_tz_trip_up(struct thermal_zone_device *tz,
>         if (!tz_dbg->nr_trips) {
>                 tze = thermal_debugfs_tz_event_alloc(tz, now);
>                 if (!tze)
> -                       return;
> +                       goto unlock;
>
>                 list_add(&tze->node, &tz_dbg->tz_episodes);
>         }
> @@ -619,6 +619,7 @@ void thermal_debug_tz_trip_up(struct thermal_zone_device *tz,
>                 (temperature - tze->trip_stats[trip_id].avg) /
>                 tze->trip_stats[trip_id].count;
>
> +unlock:
>         mutex_unlock(&thermal_dbg->lock);
>  }
>
> --

Applied, thanks!