linux-kernel - Re: [PATCH] vfio/fsl-mc: Remove unnecessary free in vfio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 08:35:49 -0700
From: Alex Williamson <alex.williamson@...hat.com>
To: Kunwu Chan <chentao@...inos.cn>
Cc: diana.craciun@....nxp.com, eric.auger@...hat.com,
 Bharat.Bhushan@....com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio/fsl-mc: Remove unnecessary free in
 vfio_set_trigger

On Fri, 12 Jan 2024 15:21:28 +0800
Kunwu Chan <chentao@...inos.cn> wrote:

> 'irq->name' is initialed by kasprintf, so there is no need
> to free it before initializing.

This is just as bogus as the vfio-platform version.  Thanks,

Alex
 
> Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> ---
>  drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> index d62fbfff20b8..31f0716e7ab3 100644
> --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> @@ -69,7 +69,6 @@ static int vfio_set_trigger(struct vfio_fsl_mc_device *vdev,
>  	hwirq = vdev->mc_dev->irqs[index]->virq;
>  	if (irq->trigger) {
>  		free_irq(hwirq, irq);
> -		kfree(irq->name);
>  		eventfd_ctx_put(irq->trigger);
>  		irq->trigger = NULL;
>  	}