linux-kernel - Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-target-v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3b9aa63-25a5-41cc-9eb7-6e7d1eacb136@linaro.org>
Date: Fri, 12 Jan 2024 16:50:25 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Frank Li <Frank.li@....com>
Cc: robh@...nel.org, alexandre.belloni@...tlin.com,
 conor.culhane@...vaco.com, gregkh@...uxfoundation.org, imx@...ts.linux.dev,
 jirislaby@...nel.org, joe@...ches.com, linux-i3c@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 miquel.raynal@...tlin.com, zbigniew.lukwinski@...ux.intel.com,
 devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org
Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c:
 silvaco,i3c-target-v1

On 12/01/2024 16:31, Frank Li wrote:
> I review previous comments. The previous RFC patches and I just want I3C
> expert review to check if there are comments about whole software
> architecture. Of course, thank you for your comments about "slave".
> 
> Go back this binding doc problem. 
> 
>   "No, it's the same device.
> 
>    Anyway, this was not tested.
> 
>    Please use scripts/get_maintainers.pl to get a list of necessary people
>    and lists to CC. It might happen, that command when run on an older
>    kernel, gives you outdated entries. Therefore please be sure you base
>    your patches on recent Linux kernel.
> 
>    You missed at least devicetree list (maybe more), so this won't be
>    tested by automated tooling. Performing review on untested code might be
>    a waste of time, thus I will skip this patch entirely till you follow
>    the process allowing the patch to be tested.
> 
>    Please kindly resend and include all necessary To/Cc entries.
>    "
> 
> It is the same devices, work at difference mode (master  and target).
> what's do you want to change to?
> 
> Copy to new file like pci/pci-ep? all context is the same, except for
> compatible string. 
> 

Apologies, I mixed up a bit patches, so this was not obvious. I meant
this comment:

https://lore.kernel.org/all/20231017201404.GA2570433-robh@kernel.org/

There is no indication in your commit msg that these concerns were
addressed.

Best regards,
Krzysztof