linux-kernel - Re: scsi_get_lba breakage in 5.10 -- Re: Linux 5.10.206

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1il3z5m4y.fsf@ca-mkp.ca.oracle.com>
Date: Thu, 11 Jan 2024 21:21:00 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: "Martin K. Petersen" <martin.petersen@...cle.com>,
        Pavel Machek
 <pavel@....cz>, bvanassche@....org, hch@....de,
        hare@...e.de, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        torvalds@...ux-foundation.org, stable@...r.kernel.org, lwn@....net,
        jslaby@...e.cz
Subject: Re: scsi_get_lba breakage in 5.10 -- Re: Linux 5.10.206


Greg,

>> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
>> index 0c4bc42b55c2..3d3d139127ee 100644
>> --- a/drivers/scsi/scsi_error.c
>> +++ b/drivers/scsi/scsi_error.c
>> @@ -1069,6 +1069,7 @@ static int scsi_send_eh_cmnd(struct scsi_cmnd *scmd, unsigned char *cmnd,
>>  
>>  	scsi_log_send(scmd);
>>  	scmd->scsi_done = scsi_eh_done;
>> +	scmd->flags |= SCMD_LAST;
>>  
>>  	/*
>>  	 * Lock sdev->state_mutex to avoid that scsi_device_quiesce() can
>> @@ -2361,6 +2362,7 @@ scsi_ioctl_reset(struct scsi_device *dev, int __user *arg)
>>  	scsi_init_command(dev, scmd);
>>  	scmd->request = rq;
>>  	scmd->cmnd = scsi_req(rq)->cmd;
>> +	scmd->flags |= SCMD_LAST;
>>  
>>  	scmd->scsi_done		= scsi_reset_provider_done_command;
>>  	memset(&scmd->sdb, 0, sizeof(scmd->sdb));
>
> Ok, I have now done this and will push out a -rc1 with these changes in
> it.

Yeah, no need to bring in all those PI updates with associated driver
changes just for this.

-- 
Martin K. Petersen	Oracle Linux Engineering