linux-kernel - Re: [PATCH v1 1/2] dt-bindings: arm: nuvoton: add Facebook Yosemite 4 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZaF56lwEi1MES89Q@heinlein.vulture-banana.ts.net>
Date: Fri, 12 Jan 2024 11:42:02 -0600
From: Patrick Williams <patrick@...cx.xyz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>,
	Avi Fishman <avifishman70@...il.com>,
	Tomer Maimon <tmaimon77@...il.com>,
	Tali Perry <tali.perry1@...il.com>,
	Patrick Venture <venture@...gle.com>, Nancy Yuen <yuenn@...gle.com>,
	Benjamin Fair <benjaminfair@...gle.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Neuschäfer <j.neuschaefer@....net>,
	openbmc@...ts.ozlabs.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: arm: nuvoton: add Facebook Yosemite
 4 board

On Fri, Jan 12, 2024 at 06:14:26PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 18:10, Patrick Williams wrote:
> > On Fri, Jan 12, 2024 at 08:10:25AM +0100, Krzysztof Kozlowski wrote:
> >> On 12/01/2024 02:36, Delphine CC Chiu wrote:
> >>> Document the new compatibles used on Facebook Yosemite 4.
> >>
> >> There is Yosemite4 board already supported. What is this for?
> >> https://lore.kernel.org/all/20240109072053.3980855-5-Delphine_CC_Chiu@wiwynn.com/
> > 
> > Yosemite4 is a server chassis which is managed by a BMC.  The BMC is on
> > a pluggable module card.  Typically we've used Aspeed chips for this,
> > but we are building an alternative BMC module using Nuvoton BMC chips.
> 
> There are few ways to solve this, like having different compatibles or
> having some shared compatibles to note common part of hardware. However
> usually the final compatible represents the final device, which here you
> use for two entirely different products. This works only for the cases
> of carrier boards, where that compatible indeed represents the same
> hardware.
> 
> Not your case. This needs fixing.

This patch:
+	model = "Facebook Yosemite 4 BMC";
+	compatible = "facebook,yosemite4-n-bmc", "nuvoton,npcm845";

Aspeed patch:
+       model = "Facebook Yosemite 4 BMC";
+       compatible = "facebook,yosemite4-bmc", "aspeed,ast2600";

These have different compatibles already ('-n' for Nuvoton).  Do we just
need the model to be clearly different also?  Maybe there is something
else I'm not understanding.

-- 
Patrick Williams

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)