linux-kernel - Re: [PATCH v3 1/2] bpf: Reject variable offset alu on PTR_TO_FLOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACkBjsaO126d1tb-6GpPe62dkqfT7ZynhkWW_WzCaz1AHiY1Tg@mail.gmail.com>
Date: Fri, 12 Jan 2024 19:02:09 +0100
From: Hao Sun <sunhao.th@...il.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: bpf <bpf@...r.kernel.org>, Willem de Bruijn <willemb@...gle.com>, 
	Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Eddy Z <eddyz87@...il.com>, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] bpf: Reject variable offset alu on PTR_TO_FLOW_KEYS

On Fri, Jan 12, 2024 at 6:57 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Fri, Jan 12, 2024 at 7:20 AM Hao Sun <sunhao.th@...il.com> wrote:
> >
> > For PTR_TO_FLOW_KEYS, check_flow_keys_access() only uses fixed off
> > for validation. However, variable offset ptr alu is not prohibited
> > for this ptr kind. So the variable offset is not checked.
>
> Why resend v3?
> What changed from v2?

Nothing changes in the first patch, the tests in the second patch are
reformatted
with a proper number of tabs after each instruction. Forgot to add changelogs.