linux-kernel - Re: [PATCH] [v2] SUNRPC: fix a memleak in gss_import_v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 19:27:40 +0000
From: Chuck Lever III <chuck.lever@...cle.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Zhipeng Lu <alexious@....edu.cn>, Jeff Layton <jlayton@...nel.org>,
        Neil
 Brown <neilb@...e.de>, Olga Kornievskaia <kolga@...app.com>,
        Dai Ngo
	<dai.ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
        Trond Myklebust
	<trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        "David
 S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>,
        Simo Sorce <simo@...hat.com>, Steve Dickson
	<steved@...hat.com>,
        Kevin Coffman <kwc@...i.umich.edu>,
        Linux NFS Mailing
 List <linux-nfs@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] SUNRPC: fix a memleak in gss_import_v2_context



> On Jan 12, 2024, at 2:24 PM, Jakub Kicinski <kuba@...nel.org> wrote:
> 
> On Fri, 12 Jan 2024 16:45:38 +0800 Zhipeng Lu wrote:
>> + if (ret) {
>> + p = ERR_PTR(ret);
>> + goto out_free;
>> + };
> 
> cocci says:
> 
> net/sunrpc/auth_gss/gss_krb5_mech.c:458:2-3: Unneeded semicolon

I planned to take this patch via NFSD's "for v6.9" branch.
I can remove that semicolon. Thanks!

--
Chuck Lever