linux-kernel - Re: [PATCH v2 3/3] iio: light: as73211: add support for as7331

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240113151549.2be0463e@jic23-huawei>
Date: Sat, 13 Jan 2024 15:15:49 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Christian Eggers <ceggers@...i.de>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Javier Carrasco <javier.carrasco.cruz@...il.com>,
 <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] iio: light: as73211: add support for as7331

> > +struct as73211_data;
> > +
> > +/**
> > + * struct spec_dev_data - device-specific data
> > + * @intensity_scale:  Function to retrieve intensity scale values.
> > + * @channel:          Device channels.
> > + * @num_channels:     Number of channels of the device.
> > + */
> > +struct spec_dev_data {  
> 
> I would call it as73211_spec_dev_data (is the C++ One Definition Rule relevant for
> the kernel?)
> 
> > +	int (*intensity_scale)(struct as73211_data *data, int chan, int *val, int *val2);
> > +	struct iio_chan_spec const *channel;  
> s/channel/channels/
> 
> > +	int num_channels;
> > +};
Both good suggestions so I've applied them both and pushed out a new version of
the togreg tree.

Thanks,
Jonathan