linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary f2fs_put_page in f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56bdcf95-2b15-4f5b-9146-e9b37bd5b62a@kernel.org>
Date: Sat, 13 Jan 2024 10:24:35 +0800
From: Chao Yu <chao@...nel.org>
To: Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
 linux-f2fs-devel@...ts.sourceforge.net
Cc: Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary f2fs_put_page in
 f2fs_rename

On 2024/1/13 1:16, Jaegeuk Kim wrote:
> [1] changed the below condition, which made f2fs_put_page() voided.
> This patch reapplies the AL's resolution in -next from [2].
> 
> -       if (S_ISDIR(old_inode->i_mode)) {
> +       if (old_is_dir && old_dir != new_dir) {
>                  old_dir_entry = f2fs_parent_dir(old_inode, &old_dir_page);
>                  if (!old_dir_entry) {
>                          if (IS_ERR(old_dir_page))
> 
> [1] 7deee77b993a ("f2fs: Avoid reading renamed directory if parent does not change")
> [2] https://lore.kernel.org/all/20231220013402.GW1674809@ZenIV/
> 
> Suggested-by: Al Viro <viro@...iv.linux.org.uk>
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,