linux-kernel - Re: [PATCH 6/6] iio: pressure: hsc030pa add sleep mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240114152734.0ecdd090@jic23-huawei>
Date: Sun, 14 Jan 2024 15:27:34 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Petre Rodan <petre.rodan@...dimension.ro>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Lars-Peter Clausen
 <lars@...afoo.de>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 6/6] iio: pressure: hsc030pa add sleep mode

On Sun, 14 Jan 2024 07:17:47 +0200
Petre Rodan <petre.rodan@...dimension.ro> wrote:

> Hi Jonathan,
> 
> On Fri, Jan 12, 2024 at 05:13:56PM +0000, Jonathan Cameron wrote:
> > On Wed, 10 Jan 2024 19:22:41 +0200
> > Petre Rodan <petre.rodan@...dimension.ro> wrote:
> >   
> > > Some custom chips from this series require a wakeup sequence before the
> > > measurement cycle is started.
> > >   
> [..]
> > > +	if (data->capabilities & HSC_CAP_SLEEP) {
> > > +		/*
> > > +		 * Send the Full Measurement Request (FMR) command on the CS
> > > +		 * line in order to wake up the sensor as per
> > > +		 * "Sleep Mode for Use with Honeywell Digital Pressure Sensors"
> > > +		 * technical note (consult the datasheet link in the header).
> > > +		 *
> > > +		 * These specifications require a dummy packet comprised only by
> > > +		 * a single byte that contains the 7bit slave address and the
> > > +		 * READ bit followed by a STOP.
> > > +		 * Because the i2c API does not allow packets without a payload,
> > > +		 * the driver sends two bytes in this implementation.
> > > +		 */
> > > +		ret = i2c_master_recv(client, &buf, 1);
> > > +		if (ret < 0)
> > > +			return ret;
> > > +	}
> > > +  
> [..]
> > > diff --git a/drivers/iio/pressure/hsc030pa_spi.c b/drivers/iio/pressure/hsc030pa_spi.c
> > > index 737197eddff0..1c139cdfe856 100644
> > > --- a/drivers/iio/pressure/hsc030pa_spi.c
> > > +++ b/drivers/iio/pressure/hsc030pa_spi.c
> > > @@ -25,12 +25,40 @@ static int hsc_spi_recv(struct hsc_data *data)
> > >  	struct spi_device *spi = to_spi_device(data->dev);
> > >  	struct spi_transfer xfer = {
> > >  		.tx_buf = NULL,
> > > -		.rx_buf = data->buffer,
> > > -		.len = HSC_REG_MEASUREMENT_RD_SIZE,
> > > +		.rx_buf = NULL,
> > > +		.len = 0,
> > >  	};
> > > +	u16 orig_cs_setup_value;
> > > +	u8 orig_cs_setup_unit;
> > > +
> > > +	if (data->capabilities & HSC_CAP_SLEEP) {
> > > +		/*
> > > +		 * Send the Full Measurement Request (FMR) command on the CS
> > > +		 * line in order to wake up the sensor as per
> > > +		 * "Sleep Mode for Use with Honeywell Digital Pressure Sensors"
> > > +		 * technical note (consult the datasheet link in the header).
> > > +		 *
> > > +		 * These specifications require the CS line to be held asserted
> > > +		 * for at least 8µs without any payload being generated.
> > > +		 */
> > > +		orig_cs_setup_value = spi->cs_setup.value;
> > > +		orig_cs_setup_unit = spi->cs_setup.unit;
> > > +		spi->cs_setup.value = 8;
> > > +		spi->cs_setup.unit = SPI_DELAY_UNIT_USECS;
> > > +		/*
> > > +		 * Send a dummy 0-size packet so that CS gets toggled.
> > > +		 * Trying to manually call spi->controller->set_cs() instead
> > > +		 * does not work as expected during the second call.
> > > +		 */  
> >
> > Do you have a reference that says the CS must be toggled on 0 length transfer?
> > If that's not specified in the SPI core somewhere then you will need to send
> > something...
> >  
> > > +		spi_sync_transfer(spi, &xfer, 1);
> > > +		spi->cs_setup.value = orig_cs_setup_value;
> > > +		spi->cs_setup.unit = orig_cs_setup_unit;
> > > +	}  
> 
> first of all thank you for the review.
> 
> I was afraid that this block will not be taken too well since I'm trying to
> achieve something that the SPI subsystem was not designed for.
> 
> the code does exactly what the datasheet specs require on my SPI controller, but
> indeed the API might change at some point making the code non-functional.
> 
> by 'sending something' you mean on the SPI bus or are you pushing me toward a
> patch to SPI core?
Should have said receive 'something' - that means that we'd clock some data
whether or not the device had any to provide.

> 
> unfortunately this chip feature is a special request only, there is no way for
> me to test what happens if the wakeup sequence also contains a payload (in both
> i2c and spi cases). the i2c wakeup code was inspired from the abp060mg driver,
> but I can't reach its maintainer to ask for details. I also can't seem to reach
> Honeywell. oh well.
> 
+CC Mark.  Discussion is about whether a zero length SPI transfer is guaranteed
to pulse the chip select.

If this is something we need, I'd prefer to see it as something a given SPI
controller would opt in to supporting or some other way of knowing it would
actually happen such as some docs that say it will work for an SPI controller
(which I doubt is the case)

Jonathan





> best regards,
> peter
>